-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF-3202 Add IsDraftingEnabled flag to Projects API #3002
base: master
Are you sure you want to change the base?
Conversation
dd4d638
to
b060bcc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3002 +/- ##
=======================================
Coverage 82.53% 82.54%
=======================================
Files 551 551
Lines 31974 31984 +10
Branches 5182 5185 +3
=======================================
+ Hits 26390 26401 +11
- Misses 4815 4826 +11
+ Partials 769 757 -12 ☔ View full report in Codecov by Sentry. |
@pmachapman Might it be more useful to indicate if a project has a draft, than whether it's enabled? Or maybe we should have both? |
This is a great idea. I will mark this as draft until I add that! |
b060bcc
to
5500a23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion
src/SIL.XForge.Scripture/Models/ParatextProject.cs
line 94 at r1 (raw file):
IsConnectable.ToString(), IsConnected.ToString(), IsDraftingEnabled.ToString(),
Missing HasDraft
5500a23
to
9ef2138
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @Nateowami)
src/SIL.XForge.Scripture/Models/ParatextProject.cs
line 94 at r1 (raw file):
Previously, Nateowami wrote…
Missing
HasDraft
Done. Thank you!
This PR adds an additional property to the /paratext-api/projects endpoint to express whether a project has drafting enabled or not.
This will make it easier for the Paratext Extension to determine what projects can be connected to that already have pre-translation drafting enabled.
This PR is marked as testing not required, as it is an API endpoint change, and so can be tested by a developer as it does not change user experience.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)